-
Notifications
You must be signed in to change notification settings - Fork 0
ci: add checks for formatting, linting, build and tests #112
Merged
+282
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be available on NTNU GitHub
So our 1 CPU VM doesn't need to install everything every single time, poor thing...
|
Finally, green checkmarks! 🎉 I also added caching in cdc546b, which is confirmed by the logs: This PR is now ready for review, although it will be easier to review after #111 is merged into main, because the diff will be easier to read. |
|
Nice work @martakam. Thanks for going above and beyond and setting this up. After my merge en commit i got to see the CI in action as well. Good call on keeping E2E tests out of the CI.. took quite some time just the ones we now have 😅 |
johahor
approved these changes
Nov 10, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR utilizes CI properly (finally).
We have checks for (both frontend and backend):
For the frontend, we also run all tests.
This PR is to be merged after #111, since it builds upon that one.
Closes #110